Closed Bug 1105828 Opened 11 years ago Closed 11 years ago

WARNING: have unconstrained inline-size... with vertical writing-modes

Categories

(Core :: Layout: Block and Inline, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: smontagu, Assigned: smontagu)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached patch Patch 1Splinter Review
The testcase for bug 1105268 fires a lot of warnings: WARNING: have unconstrained inline-size; this should only result from very large sizes, not attempts at intrinsic inline-size calculation: 'NS_UNCONSTRAINEDSIZE != computedISizeCBWM && NS_UNCONSTRAINEDSIZE != availISizeCBWM', file /Users/smontagu/mozwork/hgtree/mozilla/layout/generic/nsHTMLReflowState.cpp, line 2370 I was able to minimize the testcase to data:text/html,<div style="writing-mode: vertical-lr"> This is possibly regression from bug 1096244, but I haven't checked. The attached patch is just a copy of the fix from bug 1088547. I can't see a way to avoid duplicating the code, but maybe I'm missing something.
N.B. the patch fixes the minimized testcase, but not the original testcase from bug 1105268; investigating further.
(In reply to Simon Montagu :smontagu from comment #0) > This is possibly regression from bug 1096244, but I haven't checked. That would be bug 1096224
This fixes the original testcase (but not the minimized testcase, so we need both patches). If the comment above is true, setting UNCONSTRAINEDSIZE on this availSpace.BSize should have no effect, but waiting for a try run before requesting review (tryserver is CLOSED at time of writing).
(When I say "the comment above", I mean the comment in the first line of the diff: // The availSpace here is irrelevant to our needs - all we want // out if this setup is the block-start margin value which doesn't depend // on the childs available space.
Attachment #8529842 - Flags: review?(jfkthame)
Attachment #8529858 - Flags: review?(jfkthame)
Comment on attachment 8529842 [details] [diff] [review] Patch 1 Review of attachment 8529842 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8529842 - Flags: review?(jfkthame) → review+
Attachment #8529858 - Flags: review?(jfkthame) → review+
Assignee: nobody → smontagu
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: